Darren/dpaste
1
0
Fork 0
mirror of https://github.com/DarrenOfficial/dpaste.git synced 2024-11-15 16:12:51 +11:00
Code Issues Projects Releases Packages Wiki Activity

Fixed missing exception for 404 views in Django 1.9+

Browse source
This commit is contained in:
Martin Mahner 2017-01-19 22:46:41 +01:00
parent 12a15fffaf
commit f6d8c1c742
2 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
dpaste/tests/test_snippet.py
View file

@ -131,15 +131,11 @@ class SnippetTestCase(TestCase):
self.assertEqual(response.status_code, 404) self.assertEqual(response.status_code, 404)
self.assertEqual(Snippet.objects.count(), 0) self.assertEqual(Snippet.objects.count(), 0)
# def test_new_snippet_`_whitespace(self):
# # POST data
# data = self.valid_form_data(content=' abc')
# response = self.client.post(self.new_url, data, follow=True)
# self.assertEqual(response.status_code, 200)
# self.assertEqual(Snippet.objects.count(), 1)
# print(response.content)
# self.assertContains(response, '    abc')
def test_snippet_notfound(self):
url = reverse('snippet_details', kwargs={'snippet_id': 'abcd'})
response = self.client.get(url, follow=True)
self.assertEqual(response.status_code, 404)
# ------------------------------------------------------------------------- # -------------------------------------------------------------------------
# Reply # Reply

9
dpaste/views.py
View file

@ -3,6 +3,7 @@ import difflib
import json import json
from django.conf import settings from django.conf import settings
from django import get_version
from django.core.exceptions import ObjectDoesNotExist from django.core.exceptions import ObjectDoesNotExist
from django.core.urlresolvers import reverse from django.core.urlresolvers import reverse
from django.db.models import Count from django.db.models import Count
@ -292,8 +293,10 @@ def snippet_api(request):
# handle them here. # handle them here.
# ----------------------------------------------------------------------------- # -----------------------------------------------------------------------------
def page_not_found(request, template_name='dpaste/404.html'): def page_not_found(request, exception=None, template_name='dpaste/404.html'):
return django_page_not_found(request, template_name) # pragma: no cover if not exception: # Django <1.8
return django_page_not_found(request, template_name=template_name)
return django_page_not_found(request, exception, template_name=template_name)
def server_error(request, template_name='dpaste/500.html'): def server_error(request, template_name='dpaste/500.html'):
return django_server_error(request, template_name) # pragma: no cover return django_server_error(request, template_name=template_name) # pragma: no cover