Fix download not always returning entire requests.response object

resources/lib/downloadutils.py

@@ -224,7 +224,11 @@ class DownloadUtils():
                 if r.status_code != 401:
                     self.count_unauthorized = 0
 
-            if r.status_code == 204:
+            if return_response is True:
+                # return the entire response object
+                return r
+
+            elif r.status_code == 204:
                 # No body in the response
                 # But read (empty) content to release connection back to pool
                 # (see requests: keep-alive documentation)
@@ -258,9 +262,6 @@ class DownloadUtils():
             elif r.status_code in (200, 201):
                 # 200: OK
                 # 201: Created
-                if return_response is True:
-                    # return the entire response object
-                    return r
                 try:
                     # xml response
                     r = utils.defused_etree.fromstring(r.content)

resources/lib/plex_api/media.py

@@ -320,12 +320,11 @@ class Media(object):
                                            filename,
                                            extension)
         response = DU().downloadUrl(url, return_response=True)
-        try:
-            response.status_code
-        except AttributeError:
+        if not response.ok:
             LOG.error('Could not temporarily download subtitle %s', url)
+            LOG.error('HTTP status: %s, message: %s',
+                      response.status_code, response.text)
             return
-        else:
         LOG.debug('Writing temp subtitle to %s', path)
         with open(path_ops.encode_path(path), 'wb') as f:
             f.write(response.content)