From 770b3704e8afffdfffc3e939558cb72b6ccf3a32 Mon Sep 17 00:00:00 2001
From: croneter <kathriner.thomas@gmail.com>
Date: Sat, 13 Oct 2018 14:43:44 +0200
Subject: [PATCH] Fix Kodi crashing due to PKC memory leak

- Fixes #531
---
 resources/lib/librarysync.py | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/resources/lib/librarysync.py b/resources/lib/librarysync.py
index 66d58347..7358c44b 100644
--- a/resources/lib/librarysync.py
+++ b/resources/lib/librarysync.py
@@ -668,7 +668,15 @@ class LibrarySync(Thread):
         item_number = len(self.updatelist)
         if item_number == 0:
             return
-
+        if (utils.settings('FanartTV') == 'true' and
+                item_class in ('Movies', 'TVShows')):
+            for item in self.updatelist:
+                if item['plex_type'] in (v.PLEX_TYPE_MOVIE, v.PLEX_TYPE_SHOW):
+                    self.fanartqueue.put({
+                        'plex_id': item['plex_id'],
+                        'plex_type': item['plex_type'],
+                        'refresh': False
+                    })
         # Run through self.updatelist, get XML metadata per item
         # Initiate threads
         LOG.debug("Starting sync threads")
@@ -679,8 +687,8 @@ class LibrarySync(Thread):
         sync_info.PROCESS_METADATA_COUNT = 0
         sync_info.PROCESSING_VIEW_NAME = ''
         # Populate queue: GetMetadata
-        for item in self.updatelist:
-            download_queue.put(item)
+        for _ in range(0, len(self.updatelist)):
+            download_queue.put(self.updatelist.pop(0))
         # Spawn GetMetadata threads for downloading
         threads = []
         for _ in range(min(state.SYNC_THREAD_NUMBER, item_number)):
@@ -723,16 +731,6 @@ class LibrarySync(Thread):
             except:
                 pass
         LOG.debug("Sync threads finished")
-        if (utils.settings('FanartTV') == 'true' and
-                item_class in ('Movies', 'TVShows')):
-            for item in self.updatelist:
-                if item['plex_type'] in (v.PLEX_TYPE_MOVIE, v.PLEX_TYPE_SHOW):
-                    self.fanartqueue.put({
-                        'plex_id': item['plex_id'],
-                        'plex_type': item['plex_type'],
-                        'refresh': False
-                    })
-        self.updatelist = []
 
     @utils.log_time
     def plex_movies(self):