From ddf4999caae08836a8a93577b875024b3729bdc3 Mon Sep 17 00:00:00 2001 From: croneter Date: Sun, 23 Feb 2020 14:39:13 +0100 Subject: [PATCH 1/2] Fix PKC not burning in (and thus not showing) subtitles when transcoding --- resources/lib/plex_functions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/lib/plex_functions.py b/resources/lib/plex_functions.py index 52e403d7..8b2a2ca6 100644 --- a/resources/lib/plex_functions.py +++ b/resources/lib/plex_functions.py @@ -1078,7 +1078,7 @@ def transcoding_arguments(path, media, part, playmethod, args=None): # none, embedded, sidecar # Essentially indicating what you want to do with subtitles and state # you aren’t want it to burn them into the video (requires transcoding) - 'subtitles': 'none', + # 'subtitles': 'none', # 'subtitleSize': utils.settings('subtitleSize') 'copyts': 1 } From 690d0ce459737c38bce960202ae280319f562d93 Mon Sep 17 00:00:00 2001 From: croneter Date: Sun, 23 Feb 2020 14:45:10 +0100 Subject: [PATCH 2/2] Don't transcode subtitles to .ass when burning in --- resources/lib/variables.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/resources/lib/variables.py b/resources/lib/variables.py index 3cba3bc2..984f3834 100644 --- a/resources/lib/variables.py +++ b/resources/lib/variables.py @@ -484,8 +484,13 @@ STREAMING_HEADERS = { 'container=mpegts&' 'videoCodec=h264,hevc,mpeg4,mpeg2video&' 'audioCodec=aac,flac,vorbis,opus,ac3,eac3,mp3,mp2,pcm&' - 'subtitleCodec=ass,pgs,vobsub&' 'replace=true)' + # '+add-transcode-target(' + # 'type=subtitleProfile&' + # 'context=all&' + # 'container=ass&' + # 'codec=ass&' + # 'replace=true)' '+add-direct-play-profile(' 'type=videoProfile&' 'container=*&'