Merge pull request #1302 from croneter/fix-pix

Fix pictures from Plex picture libraries not working/displaying
This commit is contained in:
croneter 2021-01-24 17:21:25 +01:00 committed by GitHub
commit f544c4065f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 109 additions and 73 deletions

View file

@ -62,6 +62,25 @@ class Media(object):
answ['bitDepth'] = None answ['bitDepth'] = None
return answ return answ
def picture_codec(self):
"""
Returns the exif metadata of pictures. This does NOT seem to be used
reliably by Kodi skins! (e.g. not at all)
"""
return {
'exif:CameraMake': self.xml[0].get('make'), # e.g. 'Canon'
'exif:CameraModel': self.xml[0].get('model'), # e.g. 'Canon XYZ'
'exif:DateTime': self.xml.get('originallyAvailableAt', '').replace('-', ':') or None, # e.g. '2017-11-05'
'exif:Height': self.xml[0].get('height'), # e.g. '2160'
'exif:Width': self.xml[0].get('width'), # e.g. '3240'
'exif:Orientation': self.xml[0][self.part].get('orientation'), # e.g. '1'
'exif:FocalLength': self.xml[0].get('focalLength'), # TO BE VALIDATED
'exif:ExposureTime': self.xml[0].get('exposure'), # e.g. '1/1000'
'exif:ApertureFNumber': self.xml[0].get('aperture'), # e.g. 'f/5.0'
'exif:ISOequivalent': self.xml[0].get('iso'), # e.g. '1600'
# missing on Kodi side: lens, e.g. "EF50mm f/1.8 II"
}
def mediastreams(self): def mediastreams(self):
""" """
Returns the media streams for metadata purposes Returns the media streams for metadata purposes

View file

@ -136,6 +136,17 @@ def _generate_content(api):
# other fields - let's use the PMS answer to be safe # other fields - let's use the PMS answer to be safe
# See https://github.com/croneter/PlexKodiConnect/issues/1129 # See https://github.com/croneter/PlexKodiConnect/issues/1129
if not api.kodi_id or 'title' not in item: if not api.kodi_id or 'title' not in item:
if api.plex_type == v.PLEX_TYPE_PHOTO:
item = {
'title': api.title(),
'label': api.title(),
'type': api.kodi_type,
'dateadded': api.date_created(), # e.g '2019-01-03 19:40:59'
'lastplayed': api.lastplayed(), # e.g. '2019-01-04 16:05:03'
'playcount': api.viewcount(),
}
item.update(api.picture_codec())
else:
cast = [{ cast = [{
'name': x[0], 'name': x[0],
'thumbnail': x[1], 'thumbnail': x[1],
@ -180,13 +191,6 @@ def _generate_content(api):
'writer': api.writers(), # list of [str] 'writer': api.writers(), # list of [str]
'year': api.year(), # [int] 'year': api.year(), # [int]
} }
if plex_type in (v.PLEX_TYPE_EPISODE, v.PLEX_TYPE_SEASON, v.PLEX_TYPE_SHOW):
leaves = api.leave_count()
if leaves:
item['extraproperties'] = leaves
# Add all the artwork we can
item['art'] = api.artwork(full_artwork=True)
# Add all info for e.g. video and audio streams # Add all info for e.g. video and audio streams
item['streamdetails'] = api.mediastreams() item['streamdetails'] = api.mediastreams()
# Cleanup required due to the way metadatautils works # Cleanup required due to the way metadatautils works
@ -204,6 +208,12 @@ def _generate_content(api):
'position': resume, 'position': resume,
'total': api.runtime() 'total': api.runtime()
} }
if plex_type in (v.PLEX_TYPE_EPISODE, v.PLEX_TYPE_SEASON, v.PLEX_TYPE_SHOW):
leaves = api.leave_count()
if leaves:
item['extraproperties'] = leaves
# Add all the artwork we can
item['art'] = api.artwork(full_artwork=True)
item['icon'] = v.ICON_FROM_PLEXTYPE[plex_type] item['icon'] = v.ICON_FROM_PLEXTYPE[plex_type]
# Some customization # Some customization
@ -472,16 +482,18 @@ def create_listitem(item, as_tuple=True, offscreen=True,
elif "plugin://script.skin.helper" not in item['file']: elif "plugin://script.skin.helper" not in item['file']:
liz.setProperty('IsPlayable', 'true') liz.setProperty('IsPlayable', 'true')
nodetype = "Video"
if item["type"] in ["song", "album", "artist"]: if item["type"] in ["song", "album", "artist"]:
nodetype = "Music" nodetype = "music"
elif item['type'] == 'photo':
nodetype = 'pictures'
else:
nodetype = 'video'
# extra properties # extra properties
for key, value in item["extraproperties"].iteritems(): for key, value in item["extraproperties"].iteritems():
liz.setProperty(key, value) liz.setProperty(key, value)
# video infolabels if nodetype == 'video':
if nodetype == "Video":
infolabels = { infolabels = {
"title": item.get("title"), "title": item.get("title"),
"size": item.get("size"), "size": item.get("size"),
@ -532,8 +544,7 @@ def create_listitem(item, as_tuple=True, offscreen=True,
if "date" in item: if "date" in item:
infolabels["date"] = item["date"] infolabels["date"] = item["date"]
# music infolabels elif nodetype == 'music':
else:
infolabels = { infolabels = {
"title": item.get("title"), "title": item.get("title"),
"size": item.get("size"), "size": item.get("size"),
@ -553,12 +564,18 @@ def create_listitem(item, as_tuple=True, offscreen=True,
if "lastplayed" in item: if "lastplayed" in item:
infolabels["lastplayed"] = item["lastplayed"] infolabels["lastplayed"] = item["lastplayed"]
else:
# Pictures
infolabels = {
"title": item.get("title"),
'picturepath': item['file']
}
# setting the dbtype and dbid is supported from kodi krypton and up # setting the dbtype and dbid is supported from kodi krypton and up
# PKC hack: ignore empty type # PKC hack: ignore empty type
if item["type"] not in ["recording", "channel", "favourite", ""]: if item["type"] not in ["recording", "channel", "favourite", ""]:
infolabels["mediatype"] = item["type"] infolabels["mediatype"] = item["type"]
# setting the dbid on music items is not supported ? # setting the dbid on music items is not supported ?
if nodetype == "Video" and "DBID" in item["extraproperties"]: if nodetype == "video" and "DBID" in item["extraproperties"]:
infolabels["dbid"] = item["extraproperties"]["DBID"] infolabels["dbid"] = item["extraproperties"]["DBID"]
if "lastplayed" in item: if "lastplayed" in item: