Troplo/pleroma-fe
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix incorrect close of a status popover when clicking Expand inside it

Browse source 
basically Vue (3 in particular?) will make changes to DOM before this event
listener is called, and if the target is displayed using v-if, it will not
be part of the DOM at that time, and contains() will return false. so it
goes to call hidePopover() which caused this bug.
This commit is contained in:
Tusooa Zhu 2022-04-19 20:20:18 -04:00
parent 1041a38f14
commit a4ea0a30bf
No known key found for this signature in database
GPG key ID: 7B467EDE43A08224
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/components/status_body/status_body.vue
View file

@ -15,14 +15,14 @@
:emoji="status.emojis" :emoji="status.emojis"
/> />
<button <button
v-if="longSubject && showingLongSubject" v-show="longSubject && showingLongSubject"
class="button-unstyled -link tall-subject-hider" class="button-unstyled -link tall-subject-hider"
@click.prevent="toggleShowingLongSubject" @click.prevent="toggleShowingLongSubject"
> >
{{ $t("status.hide_full_subject") }} {{ $t("status.hide_full_subject") }}
</button> </button>
<button <button
v-else-if="longSubject" v-show="longSubject && !showingLongSubject"
class="button-unstyled -link tall-subject-hider" class="button-unstyled -link tall-subject-hider"
@click.prevent="toggleShowingLongSubject" @click.prevent="toggleShowingLongSubject"
> >
@ -34,7 +34,7 @@
class="text-wrapper" class="text-wrapper"
> >
<button <button
v-if="hideTallStatus" v-show="hideTallStatus"
class="button-unstyled -link tall-status-hider" class="button-unstyled -link tall-status-hider"
:class="{ '-focused': focused }" :class="{ '-focused': focused }"
@click.prevent="toggleShowMore" @click.prevent="toggleShowMore"
@ -54,7 +54,7 @@
/> />
<button <button
v-if="hideSubjectStatus" v-show="hideSubjectStatus"
class="button-unstyled -link cw-status-hider" class="button-unstyled -link cw-status-hider"
@click.prevent="toggleShowMore" @click.prevent="toggleShowMore"
> >
@ -85,7 +85,7 @@
/> />
</button> </button>
<button <button
v-if="showingMore && !fullContent" v-show="showingMore && !fullContent"
class="button-unstyled -link status-unhider" class="button-unstyled -link status-unhider"
@click.prevent="toggleShowMore" @click.prevent="toggleShowMore"
> >